CLDR-17535 Ensure testData is good for likelySubtags #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After adding the test, the current failures are the following, so need to track those down. |
|
If the tests pass, this should fix the problem, @DraganBesevic . |
I have just pushed a PR for alpha2 integration, with this problem tagged as a known issue. I will regenerate the test data for likely subtags, remove the known issue in the next round of integration and see if that works. |
DraganBesevic
approved these changes
Aug 21, 2024
srl295
approved these changes
Aug 21, 2024
macchiati
deleted the
CLDR-17535-Ensure-testData-is-good-for-likelySubtags
branch
|
@DraganBesevic sounds great, hope it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17535
The ICU integration was failing, so adding a test to verify the testData we generate, then will fix errors.
The problem was in two overrides, where a source subtag was being overridden. The solution was to change 2 lines in tools/cldr-code/src/main/java/org/unicode/cldr/tool/GenerateLikelySubtags.java that were mapping 001 to US, and add a test in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LikelySubtagsTest.java that if you have
lang_script_region => lang2_script2_region2
then
I also semi-removed GenerateLikelySubtagTests.java, because the name is confusing; people could think that is what is used to generate the test data. I didn't just remove it, because it is unclear whether we can do without it or not, but trying to run it will cause an exception, alerting us to that.
ALLOW_MANY_COMMITS=true